Skip to content

Fix failing pydatic tests #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 23, 2025
Merged

Fix failing pydatic tests #13

merged 2 commits into from
Jul 23, 2025

Conversation

bilalebi
Copy link
Contributor

@bilalebi bilalebi commented Jul 22, 2025 •
edited
Loading

  • Fixed broken tests caused by Fix type field #12
  • Added a Github action to catch failing tests before merging to main

@bilalebi bilalebi requested a review from azangru July 22, 2025 08:58
azangru
azangru approved these changes Jul 22, 2025
View reviewed changes
Copy link

@azangru azangru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The tests aren't testing the generated html, and thus don't use the is_reference field; but all right. At least they aren't failing now.

@bilalebi bilalebi merged commit d568809 into main Jul 23, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azangru azangru azangru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bilalebi @azangru